[rfile] Introduce ListKeys() method#20056
Merged
silverweed merged 4 commits intoroot-project:masterfrom Oct 22, 2025
Merged
Conversation
silverweed
requested review from
enirolf,
hageboeck,
hahnjo,
jblomer and
vepadulano
Test Results 21 files 21 suites 3d 17h 9m 20s ⏱️ For more details on these failures, see this check. Results for commit 75db7dd. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
rfile_02
branch
3 times, most recently
from
ed31e98 to
a001f6d
Compare
jblomer
reviewed
Oct 9, 2025
silverweed
changed the title
silverweed
force-pushed
the
rfile_02
branch
2 times, most recently
from
7f3f1db to
d4daafe
Compare
pcanal
reviewed
Oct 9, 2025
pcanal
reviewed
Oct 9, 2025
pcanal
reviewed
Oct 9, 2025
pcanal
reviewed
Oct 9, 2025
pcanal
reviewed
Oct 9, 2025
pcanal
reviewed
Oct 9, 2025
pcanal
reviewed
Oct 9, 2025
pcanal
reviewed
Oct 9, 2025
silverweed
force-pushed
the
rfile_02
branch
2 times, most recently
from
f8d84c1 to
b8cb541
Compare
enirolf
reviewed
Oct 14, 2025
hageboeck
approved these changes
Oct 15, 2025
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
LGTM, but see extra comments below.
silverweed
force-pushed
the
rfile_02
branch
3 times, most recently
from
84785ef to
ad5748c
Compare
pcanal
reviewed
Oct 16, 2025
vepadulano
approved these changes
Oct 17, 2025
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Overall LGTM, thanks! But consider the following comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup of #19958. Other than addressing @pcanal's comments, this PR introduces the
ListKeys()method, which iterates over the keys of some subdirectory.They do so via an iterator that returns an abridged version of TKey, currently containing only barebones information (more may be added later).
Checklist: